Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1
Notable changes:
Changes to the pnpm workspace configuration
made it more similar to other projects I've come across, such as the separation of workspaces related to apps vs packages.
worker/->apps/workers/e2e/->apps/e2e/removed vitest from the catalog because requirements around the version are different between the apps (v3, due to wrangler-related deps) and the eventual package (v4)
Moves thesupabasedirectory into thee2eproject since it's only relevant for that projectIntegrates some of the setup that currently lives on the main branch, such as:
testjob since it's related to the eventual module. for now it only runs type checks.Variety of other changes that I don't have time to write down due to personal obligations...
Open to changing or reverting anything based on needs or context that I was missing!